Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TraceChainSyncHeaderServer config value is ignored #3251

Closed
gufmar opened this issue Sep 27, 2021 · 1 comment · Fixed by #3252
Closed

[BUG] TraceChainSyncHeaderServer config value is ignored #3251

gufmar opened this issue Sep 27, 2021 · 1 comment · Fixed by #3252
Labels
bug Something isn't working

Comments

@gufmar
Copy link
Contributor

gufmar commented Sep 27, 2021 •
edited

External

Area
Other Any other topic (Delegation, Ranking, ...).

Summary
some config file tracer settings seems not having any effect on the logged lines.
this results in a huge amount of two tracers logged

66851 "ChainSyncServerEvent.TraceChainSyncRollForward"
66768 "ChainSyncServerEvent.TraceChainSyncServerRead.AddBlock"
   234 null
   234 "TraceStartLeadershipCheck"
    84 "ChainSyncServerEvent.TraceChainSyncServerReadBlocked.AddBlock"
    34 "ErrorPolicyTrace"
    14 "ChainSyncServerEvent.TraceChainSyncServerRead.RollBack"
    12 "TraceMempoolRejectedTx"
     8 "TraceAddBlockEvent.AddedToCurrentChain"
     4 "TraceMempoolAddedTx"
     3 "TraceMempoolRemoveTxs"
     3 "TraceLedgerEvent.TookSnapshot"
     1 "LogValue"

Steps to reproduce
Steps to reproduce the behavior:

  1. set TraceChainSyncHeaderServer and/or TraceChainSyncBlockServer to false
  2. restart the node
  3. watch out for ChainSyncServerEvent.TraceChainSyncRollForward and ChainSyncServerEvent.TraceChainSyncServerRead.AddBlock log lines

Expected behavior
allow tracer settings resulting in small focused log files, without thousands of repetitive debug-level content

System info (please complete the following information):

  • OS Name: Ubuntu
  • OS Version 20.04
  • Node version
    cardano-node 1.30.0 - linux-x86_64 - ghc-8.10 git rev 55a30aba3afbfda9576e22c00a95c7106861e458
@gufmar gufmar added the bug Something isn't working label Sep 27, 2021
@karknu
Copy link
Contributor

karknu commented Sep 27, 2021

The config value TraceChainSyncHeaderServer should be checked at https://github.com/input-output-hk/cardano-node/blob/ed7fdbf65f40f8e194850b87dd8c631fe26154e6/cardano-node/src/Cardano/Tracing/Tracers.hs#L539-L542

@karknu karknu changed the title [BUG] - [BUG] TraceChainSyncHeaderServer config value is ignored Sep 27, 2021
@karknu karknu mentioned this issue Sep 27, 2021
Merged
iohk-bors bot added a commit that referenced this issue Sep 28, 2021
@iohk-bors @Jimbo4350 @karknu
Merge #3177 #3252
07fd4b5 
3177: Update cli to allow datum values in the tx r=Jimbo4350 a=Jimbo4350

Resolves #2919

3252: Use traceChainSyncHeaderServer to control tracer r=karknu a=karknu

The chainSyncServerHeaderTracer tracer should be controlled by the
TraceChainSyncHeaderServer config value.

Fixes #3251. 

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
@iohk-bors iohk-bors bot closed this as completed in 959cd83 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use traceChainSyncHeaderServer to control tracer IntersectMBO/cardano-node
2 participants
@karknu @gufmar