Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply test magic argument #1761

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Apply test magic argument #1761

merged 1 commit into from
Aug 25, 2020

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 25, 2020 •
edited
Loading

Before:

$ cardano-cli shelley genesis create --genesis-dir testnet --testnet-magic 142
$ grep networkM testnet/* 2> /dev/null
testnet/genesis.json:    "networkMagic": 42,
testnet/genesis.spec.json:    "networkMagic": 42,

$ cardano-cli shelley genesis create --genesis-dir mainnet --mainnet
$ grep networkM mainnet/* 2> /dev/null
mainnet/genesis.json:    "networkMagic": 42,
mainnet/genesis.spec.json:    "networkMagic": 42,

After:

$ cardano-cli shelley genesis create --genesis-dir testnet --testnet-magic 142
$ grep networkM testnet/* 2> /dev/null
testnet/genesis.json:    "networkMagic": 142,
testnet/genesis.spec.json:    "networkMagic": 142,

$ cardano-cli shelley genesis create --genesis-dir mainnet --mainnet
$ grep networkM mainnet/* 2> /dev/null
mainnet/genesis.json:    "networkMagic": 764824073,
mainnet/genesis.spec.json:    "networkMagic": 764824073,

erikd
erikd requested changes Aug 25, 2020
View reviewed changes
cardano-cli/src/Cardano/CLI/Shelley/Run/Genesis.hs Outdated Show resolved Hide resolved
cardano-api/src/Cardano/Api/Typed/Internal.hs Outdated Show resolved Hide resolved
@newhoggy newhoggy requested a review from erikd August 25, 2020 07:52
dcoutts
dcoutts previously requested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense.

I suggest just exposing the NetworkMagic type and conversion function.

cardano-api/src/Cardano/Api/Typed/Internal.hs Outdated Show resolved Hide resolved
@newhoggy newhoggy requested a review from dcoutts August 25, 2020 22:13
@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 25, 2020

👎 Rejected by code reviews

@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 25, 2020

👎 Rejected by code reviews

@newhoggy newhoggy dismissed dcoutts’s stale review August 25, 2020 23:30

Changes adopted.

@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 25, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit ee35ed4 into master Aug 25, 2020
@iohk-bors iohk-bors bot deleted the apply-test-magic-argument branch August 25, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@intricate intricate Awaiting requested review from intricate

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@mrBliss mrBliss Awaiting requested review from mrBliss

@dcoutts dcoutts Awaiting requested review from dcoutts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@newhoggy @erikd @mrBliss @dcoutts