Improve lovelace parser failure in the cli #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
intricate,
mrBliss and
newhoggy
as code owners
Jimbo4350
force-pushed
the
jordan/fix-cli-out-of-bounds
branch
from
6efe16d
to
bd63271
Compare
Jimbo4350
force-pushed
the
jordan/fix-cli-out-of-bounds
branch
from
bd63271
to
5594fe1
Compare
intricate
approved these changes
Nov 12, 2020
newhoggy
reviewed
Nov 13, 2020
| i <- Atto.decimal | ||
| if i > toInteger (maxBound :: Word64) | ||
| then fail $ show i <> " lovelace exceeds the Word64 upper bound" | ||
| else return $ Lovelace i |
There was a problem hiding this comment.
Is lovelace allowed to be negative for the cases intended here?
There was a problem hiding this comment.
I just checked. decimal parses unsigned, so I think this is good.
dcoutts
approved these changes
Dec 8, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2063
Improved failure: