Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More precise tx output range error reporting #2217

Merged
merged 2 commits into from
Dec 16, 2020
Merged

More precise tx output range error reporting #2217

merged 2 commits into from
Dec 16, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Dec 14, 2020

Report negative tx output quantities separately from the case of too
large, and report the specific quantity (useful for the multi-asset case
where there may be many quantities).

@dcoutts
More precise tx output range error reporting
0dba48d 
Report negative tx output quantities separately from the case of too
large, and report the specific quantity (useful for the multi-asset case
where there may be many quantities).
@dcoutts dcoutts requested a review from mkoura December 14, 2020 16:45
@dcoutts
Copy link
Contributor Author

dcoutts commented Dec 14, 2020

Poor error message as spotted by @mkoura

@newhoggy
Copy link
Contributor

Also I have a question about maxBound :: Word64. Is this a valid txout value? If so, we should probably use v <= ub instead of v < ub. Disregard if maxBound is some sort of sentinel value and not a value txout value.

@newhoggy newhoggy self-requested a review December 15, 2020 20:02
@newhoggy
Copy link
Contributor

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 16, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit a379e6a into master Dec 16, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/api-fix-error-message branch December 16, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@intricate intricate intricate approved these changes

@erikd erikd Awaiting requested review from erikd

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@mrBliss mrBliss Awaiting requested review from mrBliss

@mkoura mkoura Awaiting requested review from mkoura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcoutts @newhoggy @intricate