Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of new API modules for client-to-node IPC #2230

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Dec 18, 2020

No description provided.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Cardano.Api.Certificate
Cardano.Api.Eras
Cardano.Api.Error
Cardano.Api.Fees
Cardano.Api.Hash
Cardano.Api.HasTypeProxy
Cardano.Api.IPC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might prefer Cardano.Api.Ipc. Thoughts?

@dcoutts dcoutts marked this pull request as ready for review December 18, 2020 21:03
@dcoutts
Copy link
Contributor Author

dcoutts commented Dec 21, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 21, 2020

@iohk-bors iohk-bors bot merged commit fce0a1c into master Dec 21, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/api-ipc-2 branch December 21, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants