Add support for the QueryUTxO via the new IPC API #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
requested review from
erikd,
intricate,
mrBliss and
newhoggy
as code owners
intricate
approved these changes
Dec 22, 2020
intricate
reviewed
Dec 22, 2020
cardano-api/cardano-api.cabal
Outdated
Comment on lines
39
to
40
| Cardano.Api.IPC | ||
| Cardano.Api.Query |
There was a problem hiding this comment.
I think you also need to remove these from other-modules
Jimbo4350
force-pushed
the
dcoutts/api-ipc-query-utxo
branch
from
1a82a37
to
d7302bd
Compare
There are still quite a few queries to cover. This covers just the QueryUTxO one. This requires exporting a UTxO type. For now the UTxO type has no interesting instances but the newtype wrapper is exposed which just uses the other API types in a simple way. newtype UTxO era = UTxO (Map TxIn (TxOut era)) Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
dcoutts
force-pushed
the
dcoutts/api-ipc-query-utxo
branch
from
23720a4
to
b9c43bc
Compare
dcoutts
commented
Jan 5, 2021
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 5, 2021
2238: Add support for the QueryUTxO via the new IPC API r=dcoutts a=dcoutts There are still quite a few queries to cover. This covers just the QueryUTxO one. This requires exporting a UTxO type. For now the UTxO type has no interesting instances but the newtype wrapper is exposed which just uses the other API types in a simple way. ``` newtype UTxO era = UTxO (Map TxIn (TxOut era)) ``` Co-authored-by: Duncan Coutts <duncan@well-typed.com>
|
Build failed: |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 5, 2021
2238: Add support for the QueryUTxO via the new IPC API r=dcoutts a=dcoutts There are still quite a few queries to cover. This covers just the QueryUTxO one. This requires exporting a UTxO type. For now the UTxO type has no interesting instances but the newtype wrapper is exposed which just uses the other API types in a simple way. ``` newtype UTxO era = UTxO (Map TxIn (TxOut era)) ``` Co-authored-by: Duncan Coutts <duncan@well-typed.com>
|
Build failed: |
dcoutts
force-pushed
the
dcoutts/api-ipc-query-utxo
branch
from
bd22a81
to
5a498dc
Compare
|
bors merge |
newhoggy
approved these changes
Jan 7, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still quite a few queries to cover. This covers just the
QueryUTxO one. This requires exporting a UTxO type.
For now the UTxO type has no interesting instances but the newtype
wrapper is exposed which just uses the other API types in a simple way.