Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProtocolState and LedgerState queries to api #2277

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Add ProtocolState and LedgerState queries to api #2277

merged 2 commits into from
Jan 18, 2021

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

DavidEichmann
DavidEichmann suggested changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@DavidEichmann DavidEichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to decide where to put Ledger/ProtocolState. This is otherwise pretty straightforward.

cardano-api/src/Cardano/Api/Query.hs Show resolved Hide resolved
cardano-api/src/Cardano/Api/Query.hs Show resolved Hide resolved
DavidEichmann
DavidEichmann approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@DavidEichmann DavidEichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

dcoutts
dcoutts approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 18, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 550eb5e into master Jan 18, 2021
@iohk-bors iohk-bors bot deleted the jordan/add-more-api-queries branch January 18, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@DavidEichmann DavidEichmann DavidEichmann approved these changes

@erikd erikd Awaiting requested review from erikd

@intricate intricate Awaiting requested review from intricate

@mrBliss mrBliss Awaiting requested review from mrBliss

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jimbo4350 @dcoutts @DavidEichmann