Convert flake to use haskell.nix #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigem
force-pushed
the
flake-haskell.nix
branch
4 times, most recently
from
8be92bd
to
7e6a370
Compare
jbgi
force-pushed
the
flake-haskell.nix
branch
4 times, most recently
from
017f3be
to
ca47543
Compare
jbgi
force-pushed
the
flake-haskell.nix
branch
2 times, most recently
from
8d099a1
to
09ff59e
Compare
craigem
requested review from
DavidEichmann,
dcoutts,
erikd,
Jimbo4350 and
newhoggy
as code owners
jbgi
force-pushed
the
flake-haskell.nix
branch
3 times, most recently
from
55a1900
to
8a9fa1c
Compare
jbgi
changed the title
jbgi
added
WIP
jbgi
force-pushed
the
flake-haskell.nix
branch
2 times, most recently
from
dbbb282
to
e71194a
Compare
|
bors r+ |
|
👎 Rejected by label |
disassembler
approved these changes
Apr 28, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 28, 2021
2600: Convert flake to use haskell.nix r=disassembler a=craigem Convert the existing flake.nix to use the documented [example](https://input-output-hk.github.io/haskell.nix/tutorials/getting-started-flakes/) from [haskell.nix](https://github.com/input-output-hk/haskell.nix) as a basis. Depends on input-output-hk/iohk-nix#470 Should be import `./nix/haskell.nix` with some tweaks the `haskell.nix` to get the things it needs correctly. - [X] `nix build .` will build `cardano-node` by default. - [X] `nix build .#cardano-node` to be explicit - [X] `nix build .#cardano-cli` - [X] `nix build .#cardano-ping` - [X] `nix build .#db-converter` Specific system targets can be built, ie: ``` nix build .#packages.x86_64-darwin.cardano-node ``` A `nix repl` equivalent can be reached running: `nix run .#repl` ### ToDo: - [x] Import custom `libsodium` - [x] Import `nix/haskell.nix` - [x] Provide shortcuts so applications can be built as per the above examples, rather than as `"cardano-cli:exe:cardano-cli"` - [x] Provide builds for all Cardano networks. - [x] Fix `nix repl` (replaced - see above) - [x] Remove legacy Nix files Co-authored-by: Craige McWhirter <craige.mcwhirter@iohk.io>
newhoggy
approved these changes
Apr 28, 2021
craigem
force-pushed
the
flake-haskell.nix
branch
from
7b272b2
to
71587ac
Compare
Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
craigem
force-pushed
the
flake-haskell.nix
branch
from
71587ac
to
b3260b3
Compare
newhoggy
approved these changes
Apr 28, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the existing flake.nix to use the documented example from haskell.nix as a basis.
Depends on input-output-hk/iohk-nix#470
Should be import
./nix/haskell.nixwith some tweaks thehaskell.nixto get the things it needs correctly.nix build .will buildcardano-nodeby default.nix build .#cardano-nodeto be explicitnix build .#cardano-clinix build .#cardano-pingnix build .#db-converterSpecific system targets can be built, ie:
A
nix replequivalent can be reached running:nix run .#replToDo:
libsodiumnix/haskell.nix"cardano-cli:exe:cardano-cli"nix repl(replaced - see above)