Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled getBlockHeader for Alonzo Era #3158

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Enabled getBlockHeader for Alonzo Era #3158

merged 1 commit into from
Sep 3, 2021

Conversation

bwbush
Copy link
Contributor

@bwbush bwbush commented Sep 2, 2021

This simple fix appears to resolve #3139. I've tested it as follows:

  1. scan-blocks executable running on testnet
  2. The watch-coin and watch-address modes of my chain-walking CLI https://github.com/functionally/mantis.
  3. My token-blending application, which also walks the chain to watch coins and addresses: https://github.com/functionally/pigy-genetics

I haven't run any other test suites.

dcoutts
dcoutts approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Stray TODO that didn't get done (because we didn't mark it with TODO alonzo like we did the others).

@newhoggy
Copy link
Contributor

newhoggy commented Sep 3, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 3, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 53fd9ec into IntersectMBO:master Sep 3, 2021
@newhoggy
Copy link
Contributor

newhoggy commented Sep 3, 2021

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@dcoutts dcoutts dcoutts approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Cardano.API.Block.getBlockHeader Not Implemented for Alonzo Era
3 participants
@bwbush @newhoggy @dcoutts