Fix kes period info command

[newhoggy]

No description provided.

[newhoggy]

Example output babbage:

$ CARDANO_NODE_SOCKET_PATH=example/node-spo1/node.sock cardano-cli query kes-period-info --testnet-magic 42 --op-cert-file example/node-spo1/opcert.cert
✓ Operational certificate's KES period is within the correct KES period interval
✓ The operational certificate counter agrees with the node protocol state counter
{
    "qKesCurrentKesPeriod": 0,
    "qKesEndKesInterval": 60,
    "qKesKesKeyExpiry": null,
    "qKesMaxKESEvolutions": 60,
    "qKesNodeStateOperationalCertificateNumber": 0,
    "qKesOnDiskOperationalCertificateNumber": 0,
    "qKesRemainingSlotsInKesPeriod": 7775071,
    "qKesSlotsPerKesPeriod": 129600,
    "qKesStartKesInterval": 0
}

Example output alonzo:

$ CARDANO_NODE_SOCKET_PATH=example/node-bft1/node.sock cardano-cli query kes-period-info --testnet-magic 42 --op-cert-file example/node-pool1/shelley/node.cert
✓ Operational certificate's KES period is within the correct KES period interval
✗ No blocks minted so far with the operational certificate at: example/node-pool1/shelley/node.cert
  On disk operational certificate counter: 0
{
    "qKesCurrentKesPeriod": 0,
    "qKesEndKesInterval": 60,
    "qKesKesKeyExpiry": null,
    "qKesMaxKESEvolutions": 60,
    "qKesNodeStateOperationalCertificateNumber": null,
    "qKesOnDiskOperationalCertificateNumber": 0,
    "qKesRemainingSlotsInKesPeriod": 7775972,
    "qKesSlotsPerKesPeriod": 129600,
    "qKesStartKesInterval": 0
}

Dismiss review

[Jimbo4350]

LGTM! We should ask @disassembler to test the command for us to double check its working. We should create an issue somewhere that after the hardfork we will only be able to bump the op cert counter by 1. We will need to update the command to do this check in the Babbage era onwards.

[CarlosLopezDeLara]

LGTM! We should ask @disassembler to test the command for us to double check its working. We should create an issue somewhere that after the hardfork we will only be able to bump the op cert counter by 1. We will need to update the command to do this check in the Babbage era onwards.

Issue created--> #3963

[newhoggy]

bors r+

[iohk-bors]

Build succeeded:

• buildkite/cardano-node
• ci/hydra-build:required

[gitmachtl]

Example output babbage:

$ CARDANO_NODE_SOCKET_PATH=example/node-spo1/node.sock cardano-cli query kes-period-info --testnet-magic 42 --op-cert-file example/node-spo1/opcert.cert
✓ Operational certificate's KES period is within the correct KES period interval
✓ The operational certificate counter agrees with the node protocol state counter
{
    "qKesCurrentKesPeriod": 0,
    "qKesEndKesInterval": 60,
    "qKesKesKeyExpiry": null,
    "qKesMaxKESEvolutions": 60,
    "qKesNodeStateOperationalCertificateNumber": 0,
    "qKesOnDiskOperationalCertificateNumber": 0,
    "qKesRemainingSlotsInKesPeriod": 7775071,
    "qKesSlotsPerKesPeriod": 129600,
    "qKesStartKesInterval": 0
}

is the plaintext output at the top written to /dev/stderr? otherwise it is a strang mixed format output of plaintext with json, thats not good.

[gitmachtl]

question, will the qKesNodeStateOperationalCertificateNumber be set again to null if there was no block produced in the current KesPeriod? or will this value show the latest opcert number used on chain in the past?

[gitmachtl]

this should not be greenlit with two checkmarks right? because the new opcert counter 3 is too high when the last one on chain is only 1. tested with a node in babbage-era. the current output looks like that:

✓ Operational certificate's KES period is within the correct KES period interval
✓ The operational certificate counter agrees with the node protocol state counter
{
    "qKesCurrentKesPeriod": 16,
    "qKesEndKesInterval": 136,
    "qKesKesKeyExpiry": null,
    "qKesMaxKESEvolutions": 120,
    "qKesNodeStateOperationalCertificateNumber": 1,
    "qKesOnDiskOperationalCertificateNumber": 3,
    "qKesRemainingSlotsInKesPeriod": 10342913,
    "qKesSlotsPerKesPeriod": 86400,
    "qKesStartKesInterval": 16
}

[Jimbo4350]

Why was the comment deleted?