Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New p2p topology file format #4563

Merged
merged 6 commits into from
Nov 8, 2022
Merged

New p2p topology file format #4563

merged 6 commits into from
Nov 8, 2022

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 26, 2022

Fixes #4559.

@coot coot force-pushed the coot/p2p-topology branch 3 times, most recently from 8a8bc6e to b4359f2 Compare October 26, 2022 20:02
@coot coot requested a review from bolt12 October 26, 2022 20:03
@coot coot requested a review from a team as a code owner October 27, 2022 06:05
@Jimbo4350 Jimbo4350 self-requested a review October 29, 2022 18:57
@Jimbo4350
Copy link
Contributor

One last thing, can you add a vNext section to cardano-node's change log and add this PR to it (similar to what has been done in cardano-cli and cardano-api)?

@coot coot force-pushed the coot/p2p-topology branch 2 times, most recently from b53ff4d to 6fed2ae Compare November 2, 2022 09:42
@coot
Copy link
Contributor Author

coot commented Nov 2, 2022

@Jimbo4350 I added entry in the ChangeLog; with links so it makes it easy for people to find what they need to change.

Jimbo4350
Jimbo4350 requested changes Nov 2, 2022
View reviewed changes
cardano-node/ChangeLog.md Show resolved Hide resolved
@coot coot force-pushed the coot/p2p-topology branch 2 times, most recently from 8f1b7c4 to d5e5835 Compare November 4, 2022 13:40
@Jimbo4350 Jimbo4350 self-requested a review November 4, 2022 14:44
@coot
Copy link
Contributor Author

coot commented Nov 7, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Nov 7, 2022
@iohk-bors @coot
Merge #4209 #4563
284dd45 
4209: Document how to disable ledger peers r=coot a=coot



4563: New p2p topology file format r=coot a=coot

Fixes #4559.


Co-authored-by: Marcin Szamotulski <coot@coot.me>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 7, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from input-output-hk/docs-access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@coot
Copy link
Contributor Author

coot commented Nov 8, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Nov 8, 2022
@iohk-bors @coot
Merge #4563
c708ca7 
4563: New p2p topology file format r=coot a=coot

Fixes #4559.


Co-authored-by: Marcin Szamotulski <coot@coot.me>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 8, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from input-output-hk/docs-access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

coot
coot commented Nov 8, 2022
View reviewed changes
cardano-node/ChangeLog.md Outdated Show resolved Hide resolved
@coot
Copy link
Contributor Author

coot commented Nov 8, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 8, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit ffcf2c0 into master Nov 8, 2022
@iohk-bors iohk-bors bot deleted the coot/p2p-topology branch November 8, 2022 18:20
@coot coot mentioned this pull request Nov 21, 2022
Merged
@coot coot mentioned this pull request Dec 5, 2022
Merged
mkoura added a commit to IntersectMBO/cardano-node-tests that referenced this pull request Feb 28, 2023
@mkoura
Add support for the new P2P topology format
f87843e 
See
* <IntersectMBO/cardano-node#4559>
* <IntersectMBO/cardano-node#4563>
@mkoura mkoura mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgahryniuk olgahryniuk olgahryniuk approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@bolt12 bolt12 bolt12 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@deepfire deepfire Awaiting requested review from deepfire

@jutaro jutaro Awaiting requested review from jutaro

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Simplify p2p topology format
4 participants
@coot @Jimbo4350 @bolt12 @olgahryniuk