Straight line code for tx commands #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/straight-line-code-for-tx-commands
branch
2 times, most recently
from
335c1f5
to
5eb0a7b
Compare
newhoggy
force-pushed
the
newhoggy/straight-line-code-for-tx-commands
branch
2 times, most recently
from
dd497b9
to
14b6b93
Compare
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/straight-line-code-for-tx-commands
branch
from
20b4dea
to
631b8c9
Compare
newhoggy
force-pushed
the
newhoggy/straight-line-code-for-tx-commands
branch
2 times, most recently
from
7c6ca34
to
9bc940c
Compare
Jimbo4350
approved these changes
Mar 20, 2023
| <- firstExceptT (ShelleyTxCmdQueryConvenienceError . AcqFailure) | ||
| . newExceptT $ determineEra cModeParams localNodeConnInfo | ||
| AnyCardanoEra nodeEra <- lift (determineEra cModeParams localNodeConnInfo) | ||
| & onLeft (throwE . ShelleyTxCmdQueryConvenienceError . AcqFailure) |
There was a problem hiding this comment.
not a major deal but I'd like to stick with left in future
There was a problem hiding this comment.
I removed throwE from the commit history of the PR.
newhoggy
force-pushed
the
newhoggy/straight-line-code-for-tx-commands
branch
from
9bc940c
to
ba46bd6
Compare
newhoggy
force-pushed
the
newhoggy/straight-line-code-for-tx-commands
branch
from
ba46bd6
to
8cf9027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.