Bump CHaP and remove most constraints from the cabal file #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
requested review from
a team,
deepfire,
mgmeier,
fmaste,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
michaelpj
commented
Mar 22, 2023
| hedgehog >= 1.0 | ||
| , dependent-sum >= 0.7.1.0 | ||
| , bimap >= 0.4.0 | ||
| , libsystemd-journal >= 1.4.4 |
There was a problem hiding this comment.
moved to cabal file
michaelpj
commented
Mar 22, 2023
| constraints: | ||
| hedgehog >= 1.0 | ||
| , dependent-sum >= 0.7.1.0 | ||
| , bimap >= 0.4.0 |
There was a problem hiding this comment.
moved to cabal file
michaelpj
commented
Mar 22, 2023
| , dependent-sum >= 0.7.1.0 | ||
| , bimap >= 0.4.0 | ||
| , libsystemd-journal >= 1.4.4 | ||
| , systemd >= 2.3.0 |
There was a problem hiding this comment.
moved to cabal file
michaelpj
commented
Mar 22, 2023
| , tree-diff >= 0.2.2 | ||
|
|
||
| -- Haddock is broken in this release. Waiting for the next release | ||
| , http2 < 4.0.0 |
There was a problem hiding this comment.
4.1 is released in Hackage with the fix
|
Ah, some are still needed for 9.2 it seems. |
michaelpj
force-pushed
the
mpj/remove-constraints
branch
from
4fcf29d
to
9c100d0
Compare
|
Perhaps @newhoggy could review. |
I revised a bunch of things in CHaP and the constraints are not needed any more.
michaelpj
force-pushed
the
mpj/remove-constraints
branch
from
9c100d0
to
41ad5d1
Compare
|
Maybe @disassembler ? |
newhoggy
approved these changes
Mar 27, 2023
|
bors r+ |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Validation Failed","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revised a bunch of things in CHaP and the constraints are not needed
any more.