CAD-455 log versioning: make pretty #542

deepfire · 2020-02-05T23:47:12Z

We used to have the following in the structured log:

{"at":"2020-02-05T23:39:27.05Z","env": "fromList [(\"value\",String \"Release-1.0.0\")]:0.1.10.1","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...}

This makes it more useful -- by tracking node version & commit id in the env field:

{"at":"2020-02-05T23:39:27.05Z","env":"1.5.0:79a04","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...}

Note

This depends on input-output-hk/iohk-monitoring-framework#514 being merged first.

CodiePP

nice idea about "era", but not necessary.
the cabal file "cardano-node.cabal" defines the version of the node
this version needs to be added to 'env' from module "Paths_cardano_node"

deepfire · 2020-02-11T19:56:34Z

@CodiePP, done.

CodiePP · 2020-02-12T17:08:45Z

cardano-config/src/Cardano/Config/Logging.hs

+  Config.setTextOption logConfig "appversion" ver
+  Config.setTextOption logConfig "appcommit" gitRev
+  T.putStrLn $ "ver: " <> ver
+  T.putStrLn $ "rev: " <> gitRev


we don't need this debug output.

Ah gotcha, thank you!

shell.nix

stack.yaml

cardano-config/cardano-config.cabal

CodiePP

minor changes/explanations needed

CodiePP · 2020-02-13T10:02:59Z

cardano-config/src/Cardano/Config/Logging.hs

-      then Cardano.BM.Backend.Editor.plugin logConfig trace switchBoard
-               >>= loadPlugin switchBoard
-      else pure ()
+      when (p > 0) $


CodiePP · 2020-02-13T13:44:33Z

bors r+

542: CAD-455 log versioning: make pretty r=CodiePP a=deepfire We used to have the following in the structured log: ``` {"at":"2020-02-05T23:39:27.05Z","env": "fromList [(\"value\",String \"Release-1.0.0\")]:0.1.10.1","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` This makes it more useful -- by tracking node version & commit id in the `env` field: ``` {"at":"2020-02-05T23:39:27.05Z","env":"1.5.0:79a04","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` # Note This depends on input-output-hk/iohk-monitoring-framework#514 being merged first. Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>

iohk-bors · 2020-02-13T14:58:09Z

Build failed

buildkite/cardano-node

CodiePP · 2020-02-13T14:58:19Z

bors r+

iohk-bors · 2020-02-13T15:24:56Z

This PR was included in a batch with a merge conflict, it will be automatically retried

iohk-bors · 2020-02-13T15:25:10Z

Merge conflict

CodiePP · 2020-02-13T20:18:18Z

bors r+

542: CAD-455 log versioning: make pretty r=CodiePP a=deepfire We used to have the following in the structured log: ``` {"at":"2020-02-05T23:39:27.05Z","env": "fromList [(\"value\",String \"Release-1.0.0\")]:0.1.10.1","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` This makes it more useful -- by tracking node version & commit id in the `env` field: ``` {"at":"2020-02-05T23:39:27.05Z","env":"1.5.0:79a04","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` # Note This depends on input-output-hk/iohk-monitoring-framework#514 being merged first. Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>

iohk-bors · 2020-02-13T20:42:01Z

Build succeeded

Changes in iohk-monitoring: - CAD 484 | trace forwarding: named pipes for windows (#537) - cabal.project: Bump Hackage index-state - CAD-710 textual representation from structured trace (#536) - Fix ghc provided by stack-shell.nix (#541) - Update stack.yaml (#542) - update katip to latest version

deepfire requested a review from CodiePP February 5, 2020 23:47

deepfire force-pushed the cad-455-log-versioning branch 2 times, most recently from d94284c to edc0507 Compare February 6, 2020 13:06

CodiePP requested a review from disassembler February 6, 2020 18:55

CodiePP suggested changes Feb 6, 2020

View reviewed changes

deepfire force-pushed the cad-455-log-versioning branch 3 times, most recently from 111e120 to 10ec4cf Compare February 11, 2020 19:52