Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-426 Tx gen: submit transactions to Explorer's WebAPI. #549

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

denisshevchenko
Copy link
Contributor

We need a way to test the transaction submission POST API in the explorer (cardano-tx-submit-webapi executable). Please see Testing cardano-tx-submit-webapi for current workflow.

@denisshevchenko denisshevchenko self-assigned this Feb 7, 2020
@denisshevchenko denisshevchenko added the WIP Work In Progress (cannot be merged yet) label Feb 7, 2020
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes in comments.

@denisshevchenko denisshevchenko force-pushed the cad-426-submit-txs-to-explorer-webapi branch from ef44633 to b9624b9 Compare February 7, 2020 11:18
@denisshevchenko denisshevchenko force-pushed the cad-426-submit-txs-to-explorer-webapi branch 4 times, most recently from 49273f5 to a25e3a8 Compare February 11, 2020 08:59
@denisshevchenko denisshevchenko removed the WIP Work In Progress (cannot be merged yet) label Feb 11, 2020
Copy link
Contributor

@CodiePP CodiePP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good documentation
just minor issues raised.

@denisshevchenko denisshevchenko force-pushed the cad-426-submit-txs-to-explorer-webapi branch from a25e3a8 to bed2e44 Compare February 11, 2020 17:49
@CodiePP
Copy link
Contributor

CodiePP commented Feb 11, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 11, 2020
549: CAD-426 Tx gen: submit transactions to Explorer's WebAPI. r=CodiePP a=denisshevchenko

We need a way to test the transaction submission POST API in the explorer (`cardano-tx-submit-webapi` executable). Please see [Testing cardano-tx-submit-webapi](https://github.com/input-output-hk/cardano-explorer/blob/master/cardano-tx-submit/testing-tx-submit.md) for current workflow.

Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 11, 2020

@iohk-bors iohk-bors bot merged commit bed2e44 into master Feb 11, 2020
@iohk-bors iohk-bors bot deleted the cad-426-submit-txs-to-explorer-webapi branch February 11, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants