Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky calls to by byDeadlineM in cardano-testnet #5707

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

Jimbo4350
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 requested a review from a team as a code owner March 5, 2024 19:31
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-flaky-calls-to-byDeadlineM branch from e8be723 to 273d042 Compare March 5, 2024 19:58
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-flaky-calls-to-byDeadlineM branch from 273d042 to cfd1cab Compare March 5, 2024 19:59
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Jimbo4350 Jimbo4350 merged commit 479df51 into master Mar 6, 2024
22 of 23 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/remove-flaky-calls-to-byDeadlineM branch March 6, 2024 13:55
mgmeier pushed a commit that referenced this pull request Apr 11, 2024
* Use waitUntilEpoch in hprop_leadershipSchedule

* Remove byDeadlineM when querying the leadership schedule in
hprop_leadershipSchedule

* Replace with byDeadlineM with waitUntilEpoch in hprop_stakeSnapshot
mgmeier pushed a commit that referenced this pull request May 8, 2024
* Use waitUntilEpoch in hprop_leadershipSchedule

* Remove byDeadlineM when querying the leadership schedule in
hprop_leadershipSchedule

* Replace with byDeadlineM with waitUntilEpoch in hprop_stakeSnapshot
mgmeier pushed a commit that referenced this pull request May 13, 2024
* Use waitUntilEpoch in hprop_leadershipSchedule

* Remove byDeadlineM when querying the leadership schedule in
hprop_leadershipSchedule

* Replace with byDeadlineM with waitUntilEpoch in hprop_stakeSnapshot
mgmeier pushed a commit that referenced this pull request May 15, 2024
* Use waitUntilEpoch in hprop_leadershipSchedule

* Remove byDeadlineM when querying the leadership schedule in
hprop_leadershipSchedule

* Replace with byDeadlineM with waitUntilEpoch in hprop_stakeSnapshot
mgmeier pushed a commit that referenced this pull request May 18, 2024
* Use waitUntilEpoch in hprop_leadershipSchedule

* Remove byDeadlineM when querying the leadership schedule in
hprop_leadershipSchedule

* Replace with byDeadlineM with waitUntilEpoch in hprop_stakeSnapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants