Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count votes in Propose Constitution test before ratification #5827

Merged

Conversation

carbolymer
Copy link
Contributor

Description

This PR consists of two commits:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer marked this pull request as ready for review May 7, 2024 13:07
@carbolymer carbolymer requested a review from a team as a code owner May 7, 2024 13:07
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment.

@carbolymer carbolymer force-pushed the mgalazyn/test/count-constitution-votes-before-adpoption branch from 00d5598 to ab78747 Compare May 8, 2024 08:18
@carbolymer carbolymer enabled auto-merge May 8, 2024 08:18
@carbolymer carbolymer added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit 6c36c4d May 8, 2024
22 checks passed
@carbolymer carbolymer deleted the mgalazyn/test/count-constitution-votes-before-adpoption branch May 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants