Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and related code #973

Merged
merged 2 commits into from May 15, 2020
Merged

Conversation

intricate
Copy link
Contributor

No description provided.

@intricate intricate self-assigned this May 14, 2020
@intricate intricate force-pushed the intricate/deps-20200514 branch 2 times, most recently from 578e4d1 to aa90003 Compare May 15, 2020 03:14
@intricate intricate marked this pull request as ready for review May 15, 2020 03:14
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but we need to be able to forge blocks :)

Nothing -> return TxSubmitSuccess
Just err -> return (TxSubmitFailureByron err)
SubmitSuccess -> return TxSubmitSuccess
SubmitFail err -> return (TxSubmitFailureByron err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

-- This test has been disabled because 'Shelley.Spec.Ledger.Address.getByron'
-- has not been implemented yet and just 'panic's.
_prop_roundtrip_AddressByron_hex :: Property
_prop_roundtrip_AddressByron_hex =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@intricate
Copy link
Contributor Author

Awaiting the merge of IntersectMBO/ouroboros-network#2094 to remedy the block forging problem.

@nc6
Copy link
Contributor

nc6 commented May 15, 2020

That PR is now merged!

@dcoutts
Copy link
Contributor

dcoutts commented May 15, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 15, 2020

@iohk-bors iohk-bors bot merged commit 121af4a into master May 15, 2020
@iohk-bors iohk-bors bot deleted the intricate/deps-20200514 branch May 15, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants