Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to 1.20.0 node dependencies #20

Merged
merged 1 commit into from
Sep 22, 2020
Merged

bump to 1.20.0 node dependencies #20

merged 1 commit into from
Sep 22, 2020

Conversation

paweljakubas
Copy link
Contributor

No description provided.

@paweljakubas paweljakubas added the enhancement New feature or request label Sep 22, 2020
@paweljakubas paweljakubas requested a review from a team September 22, 2020 08:54
@paweljakubas paweljakubas self-assigned this Sep 22, 2020
hasufell
hasufell reviewed Sep 22, 2020
View reviewed changes
stack.yaml
@@ -1,4 +1,4 @@
resolver: https://raw.githubusercontent.com/input-output-hk/cardano-haskell/da70d67ff662b85e72e1f203defbf5e3028d03cd/snapshots/cardano-1.19.1.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we commit this file to the repository:

  • easier to view/grep the dependencies
  • unbreaks stack2cabal (currently doesn't handle remote urls in resolver)
  • more static than a url

@paweljakubas paweljakubas merged commit 218cdc2 into master Sep 22, 2020
@paweljakubas paweljakubas deleted the paweljakubas/bump-cardano-node branch September 22, 2020 10:16
@hasufell
Copy link
Contributor

@paweljakubas did you see my comment?

@paweljakubas
Copy link
Contributor Author

@hasufell oh, sorry, PR approve went to me and I automatically merge it...

Frankly speaking I tried here to comply with practice we use in other repos, like cardano-wallet, cardano-addresses.... Maybe it is good idea to pursue the approach you recommend, first discuss it in our Slack channel, and then adopt in all repos at once to have this level consistency? What do you think? I do not feel expert in those things and always try to comply with pattern used in other repos

@KtorZ @rvl what are your opinions here?

@hasufell
Copy link
Contributor

I don't have a strong opinion. I might just fork stack2cabal anyway, since upstream isn't very active.

@rvl
Copy link
Contributor

rvl commented Sep 22, 2020

I suspect that the real objection to resolver URLs is that stack2cabal doesn't work with them and the other reasons are just padding.

Anviking added a commit to cardano-foundation/cardano-wallet that referenced this pull request Sep 22, 2020
@Anviking
Bump cardano-transactions
56e1e8c 
Includes:
IntersectMBO/cardano-transactions#20
IntersectMBO/cardano-transactions#17
Anviking added a commit to cardano-foundation/cardano-wallet that referenced this pull request Sep 22, 2020
@Anviking
Bump cardano-transactions
21a6cf2 
Includes:
IntersectMBO/cardano-transactions#20
IntersectMBO/cardano-transactions#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasufell hasufell hasufell left review comments

@rvl rvl rvl approved these changes

Assignees

@paweljakubas paweljakubas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paweljakubas @hasufell @rvl