Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No DReps found card with extra one result #1019

Closed
vercia opened this issue May 14, 2024 · 1 comment · Fixed by #1022
Closed

No DReps found card with extra one result #1019

vercia opened this issue May 14, 2024 · 1 comment · Fixed by #1022
Assignees
@vercia
Labels
🐛 Bug Something isn't working

Comments

@vercia
Copy link
Collaborator

vercia commented May 14, 2024 •
edited
Loading

Context & versions

dev

Steps to reproduce

  1. Go to DRep Directory page when wallet is disconnected
  2. Enter something to input to show no results

Actual behavior

The empty card has shown and one result under this.
Zrzut ekranu 2024-05-14 o 10 25 11

Expected behavior

It should show only empty card if there are no results.
@vercia vercia mentioned this issue May 14, 2024
Merged
5 tasks
@vercia vercia linked a pull request May 14, 2024 that will close this issue
fix/1019-empty-drep-directory-with-extra-result #1022
Merged
5 tasks
@pmbinapps pmbinapps added the 🐛 Bug Something isn't working label May 14, 2024
@pmbinapps
Copy link

Also results are doubled when existing drepid is given:

Image

@MSzalowski MSzalowski mentioned this issue May 15, 2024
Merged
MSzalowski added a commit that referenced this issue May 16, 2024
@MSzalowski
Merge pull request #1030 from IntersectMBO/develop
f307ebd 
Sync test with develop: #957, #1028, #928, #1019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vercia vercia

Labels
🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/1019-empty-drep-directory-with-extra-result IntersectMBO/govtool
2 participants
@vercia @pmbinapps