Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint, tsc and prettier to github actions #512

Closed
MSzalowski opened this issue Mar 19, 2024 · 1 comment · Fixed by #513
Closed

Add eslint, tsc and prettier to github actions #512

MSzalowski opened this issue Mar 19, 2024 · 1 comment · Fixed by #513
Assignees
Labels
Ready for staging This indicates that issue has been tested and might be safely transfered to staging 🔩 Tech debt

Comments

@MSzalowski
Copy link
Contributor

Why

To check the code quality of delivered code.

What

Add github action that should execute eslint, tsc and prettier.

How

In github actions, create new workflow that for govtool/frontend package will execute eslint, tsc (without emit) and prettier to enforce accepted code style.

@MSzalowski MSzalowski added this to the Tech debt milestone Mar 19, 2024
@MSzalowski MSzalowski self-assigned this Mar 19, 2024
@MSzalowski MSzalowski linked a pull request Mar 19, 2024 that will close this issue
5 tasks
MSzalowski added a commit that referenced this issue Mar 19, 2024
MSzalowski added a commit that referenced this issue Mar 20, 2024
MSzalowski added a commit that referenced this issue Mar 20, 2024
…d-prettier-to-github-actions

[#512] chore: add type checking & lint workflow to github actions
@placek placek mentioned this issue Mar 20, 2024
@pmbinapps
Copy link

OK - workflows added

Note: @MSzalowski the workflow marked on red seems to be not needed

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for staging This indicates that issue has been tested and might be safely transfered to staging 🔩 Tech debt
Projects
Status: In staging
Development

Successfully merging a pull request may close this issue.

2 participants