Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA Display - Searching - View all - misleading text when no items are found #605

Closed
pmbinapps opened this issue Apr 2, 2024 · 1 comment · Fixed by #623
Closed

GA Display - Searching - View all - misleading text when no items are found #605

pmbinapps opened this issue Apr 2, 2024 · 1 comment · Fixed by #623
Assignees
@Sworzen1 @pmbinapps
Labels
🐛 Bug Something isn't working Ready for staging This indicates that issue has been tested and might be safely transfered to staging

Comments

@pmbinapps
Copy link

To reproduce:

  1. Go to https://test-sanchonet.govtool.byron.network/connected/governance_actions
  2. Go to a category Treasury Withdrawals and click View all
  3. Type string that won't be found - text eg: appears:

Governnance actions with category TreasuryWithdrawals don't exist.

Image
@pmbinapps pmbinapps added the 🐛 Bug Something isn't working label Apr 4, 2024
@Sworzen1 Sworzen1 assigned Sworzen1 and unassigned MSzalowski Apr 4, 2024
Sworzen1 added a commit that referenced this issue Apr 4, 2024
@Sworzen1
[#605] empty state for search GAs
f260c8c
@Sworzen1 Sworzen1 linked a pull request Apr 4, 2024 that will close this issue
fix/605-ga-display-searching-misleading-text-when-no-items-are-found #623
Merged
5 tasks
@pmbinapps
Copy link
Author

OK NOW:

Image

@pmbinapps pmbinapps self-assigned this Apr 5, 2024
@pmbinapps pmbinapps added the Ready for staging This indicates that issue has been tested and might be safely transfered to staging label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sworzen1 Sworzen1

@pmbinapps pmbinapps

Labels
🐛 Bug Something isn't working Ready for staging This indicates that issue has been tested and might be safely transfered to staging
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/605-ga-display-searching-misleading-text-when-no-items-are-found IntersectMBO/govtool
3 participants
@MSzalowski @Sworzen1 @pmbinapps