Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1141): change error modal for incompatible wallets #1293

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(#1141): change error modal for incompatible wallets #1293

wants to merge 1 commit into from
+120 −36

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • change way of filtering out cip-95 wallets
  • display error modal when wallet does not support the enabledExtensions

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jun 14, 2024 that may be closed by this pull request
[BUG] Support Incompatible Wallets #1141
Closed
@MSzalowski MSzalowski mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1 Sworzen1 is a code owner

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak JanJaroszczak is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Support Incompatible Wallets
1 participant
@MSzalowski