Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sl/disable metadata validation #1540

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

disassembler
Copy link
Contributor

List of changes

  • Add / Fix / Change / Remove

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@disassembler disassembler force-pushed the sl/disable-metadata-validation branch from 98d65a4 to 1012c29 Compare July 9, 2024 14:41
@MSzalowski
Copy link
Contributor

I would be more than happy to get rid of the metadata validation service and depend only on the db-sync.

But at this moment, that should be working only for the validations of the CIP-108 metadatas, but CIP-119 is not yet supported by GovTool and metadata validation provides some "bridge" for validation of this non-CIP DRep metadata. So that, we cannot fully get rid of this until CIP-119 is fully supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants