Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#216] use Accordion from MUI to improve user experience #438

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[#216] use Accordion from MUI to improve user experience #438

merged 1 commit into from
Mar 8, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Mar 8, 2024 •
edited
Loading

List of changes

  • Change Automated Voting Options expander to use MUI Accordion to improve user experience and accessability

Checklist

  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka added 🖥 Frontend Frontend related 🔍 DRep directory Changes related to DRep explorer labels Mar 8, 2024
MSzalowski
MSzalowski approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good 💪

govtool/frontend/src/theme.ts Outdated
theme.shadows[2] = "0px 1px 2px 0px rgba(0, 51, 173, 0.08), 0px 2px 10px 2px rgba(0, 51, 173, 0.15)";
theme.shadows[3] = "0px 1px 3px 0px rgba(0, 51, 173, 0.08), 0px 4px 12px 3px rgba(0, 51, 173, 0.15)";
theme.shadows[4] = "0px 2px 3px 0px rgba(0, 51, 173, 0.08), 0px 6px 14px 4px rgba(0, 51, 173, 0.15)";
theme.shadows[5] = "0px 4px 4px 0px rgba(0, 51, 173, 0.08), 0px 8px 20px 6px rgba(0, 51, 173, 0.15)";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No EOL

@jdyczka jdyczka force-pushed the feat/216-automated-voting-options branch from 786279b to d25e8da Compare March 8, 2024 14:07
@jdyczka jdyczka merged commit e641f91 into feat/99-drep-directory Mar 8, 2024
1 check passed
@jdyczka jdyczka deleted the feat/216-automated-voting-options branch March 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
🔍 DRep directory Changes related to DRep explorer 🖥 Frontend Frontend related On Feature Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdyczka @MSzalowski @j-dyczka