Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#507] feat: add frontend test github workflow #508

Merged

Conversation

MSzalowski
Copy link
Contributor

Set up test_frontend workflow to dispatch automated tests on every pull request.

List of changes

  • add frontend test github workflow that executes test script in govtool/frontend package.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a minor typo, looks solid. Good job so far!

.github/workflows/test_frontentd.yml Outdated Show resolved Hide resolved
Set up test_frontend workflow to dispatch automated tests on every pull request.
@MSzalowski MSzalowski force-pushed the feat/507/add-frontend-package-unit-tests-to-github-workflow branch from c94ae49 to 4cda470 Compare March 19, 2024 10:37
Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MSzalowski MSzalowski merged commit ffd1129 into develop Mar 19, 2024
1 check failed
@MSzalowski MSzalowski deleted the feat/507/add-frontend-package-unit-tests-to-github-workflow branch March 19, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants