Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote Context #568

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Vote Context #568

merged 1 commit into from
Mar 27, 2024

Conversation

JanJaroszczak
Copy link
Contributor

@JanJaroszczak JanJaroszczak commented Mar 27, 2024 •
edited
Loading

List of changes

  • Possibility of adding voting context.
    VOTE_TEST_CONTEXT will need to be adjusted later as its final form it not known yet.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

MSzalowski
MSzalowski approved these changes Mar 27, 2024
View reviewed changes
govtool/frontend/src/hooks/forms/useVoteContextForm.tsx
reset,
} = useFormContext<VoteContextFormValues>();

const generateMetadata = useCallback(async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not now, but I think that as it shares a lot of logic it should be handled by independent service

@JanJaroszczak JanJaroszczak merged commit fa89b5f into develop Mar 27, 2024
4 checks passed
@JanJaroszczak JanJaroszczak deleted the vote-context branch March 27, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1 Sworzen1 is a code owner

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JanJaroszczak @MSzalowski