Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lsm- prefix of Run record fields #172

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

mheinzel
Copy link
Collaborator

As mentioned in #166 (comment), this is a similar change as for RunBuilder. No other types have these prefixes. Since we're refactoring a few things at the moment, it seems like a good opportunity to make this change.

Copy link
Collaborator

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheinzel mheinzel force-pushed the mheinzel/remove-field-prefix branch from 9e8cf03 to 90e9f43 Compare April 16, 2024 07:34
@mheinzel mheinzel added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit f3bbdd1 Apr 16, 2024
12 checks passed
@mheinzel mheinzel deleted the mheinzel/remove-field-prefix branch April 16, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants