Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not even propagate future headers (#525)
@njd42 and I came up with this idea a couple weeks ago, during a chat about the vagaries of NTP/clocks/etc. See the commit message of the 'consensus: do not even propagate future headers' commit. The main concrete benefits: - It's a step towards Chronos and that helps simplify/ground our story around future blocks. - A network-load optimization of sorts: if someone with a horribly out of sync clock sends a block 60 seconds early, the direct neighbors won't even propagate it.
- Loading branch information
Showing
12 changed files
with
865 additions
and
218 deletions.
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
...consensus-diffusion/changelog.d/20231129_105548_nick.frisby_ChainSync_future.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<!-- | ||
A new scriv changelog fragment. | ||
Uncomment the section that is right (remove the HTML comment wrapper). | ||
--> | ||
|
||
<!-- | ||
### Patch | ||
- A bullet item for the Patch category. | ||
--> | ||
<!-- | ||
### Non-Breaking | ||
- A bullet item for the Non-Breaking category. | ||
--> | ||
|
||
### Breaking | ||
|
||
- Integrate the new `InFutureCheck` in the ChainSync client, which requires new | ||
fields in `NodeKernalArgs`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
ouroboros-consensus/changelog.d/20231129_105543_nick.frisby_ChainSync_future.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<!-- | ||
A new scriv changelog fragment. | ||
Uncomment the section that is right (remove the HTML comment wrapper). | ||
--> | ||
|
||
<!-- | ||
### Patch | ||
- A bullet item for the Patch category. | ||
--> | ||
<!-- | ||
### Non-Breaking | ||
- A bullet item for the Non-Breaking category. | ||
--> | ||
### Breaking | ||
|
||
- Added a new `InFutureCheck` to the ChainSync client, which requires | ||
additional arguments to the 'chainSyncClient' definition. The node no longer | ||
propagates headers/blocks from the future: a ChainSync client thread now | ||
sleeps until the received header is no longer from the future. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.