-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Praos chain order: fix issue no-related transitivity edge case
When we only compare the issue numbers when the issuers and (new) the slot numbers are the same, the transitivity laws work out. The motivation for the issue number is not impacted by this change.
- Loading branch information
Showing
3 changed files
with
29 additions
and
21 deletions.
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
...angelog.d/20240503_194253_alexander.esgen_praos_chain_order_truly_transitive.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
### Non-Breaking | ||
|
||
- Changed the Praos chain order such that for two blocks `A` and `B` by the same | ||
issuer with the same block number, `A` is now preferred over `B` only if `A` | ||
has a higher issue number *and* (new) `A` and `B` are in the same slot. | ||
|
||
This is in line with the motiviation for the issue number tiebreaker, and | ||
fixes the transitivity of the `Ord PraosChainSelectView` instance in a special | ||
case. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters