-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port some code from the UTXO-HD branch to main #1054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
5 times, most recently
from
April 11, 2024 11:35
8995649
to
1e29f56
Compare
Follow-ups:
|
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
from
April 11, 2024 13:21
b617d96
to
6297b22
Compare
amesgen
reviewed
Apr 11, 2024
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ImmutableDB/Stream.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/MonadSTM/RAWLock.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/MonadSTM/RAWLock.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/VolatileDB/Impl.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/unstable-mock-block/Ouroboros/Consensus/Mock/Ledger/Address.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Mempool/Impl/Common.hs
Outdated
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
4 times, most recently
from
April 15, 2024 10:38
8b974a4
to
39c6de7
Compare
nfrisby
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. I made some minor comments (eg naming, etc).
I did not thoroughly check the changelog for exhaustiveness.
...boros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Block.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Block/RealPoint.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Block/RealPoint.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/Args.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/EarlyExit.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Mempool/API.hs
Outdated
Show resolved
Hide resolved
Also explicitly enable PolyKinds in some SOP types Co-authored-by: Joris Dral <joris@well-typed.com>
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
from
April 16, 2024 09:52
39c6de7
to
e0a6bf3
Compare
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
from
April 16, 2024 10:07
e0a6bf3
to
aec635d
Compare
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
from
April 16, 2024 10:10
aec635d
to
8a152c5
Compare
dnadales
approved these changes
Apr 16, 2024
ouroboros-consensus-cardano/src/byron/Ouroboros/Consensus/Byron/Ledger/Ledger.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Ledger/Basics.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/Types.hs
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
from
April 16, 2024 11:32
8a152c5
to
3c8d1e8
Compare
- When opening it will also trace the maximum slot seen - A trace will be emitted on closing
jasagredo
force-pushed
the
js/port-some-utxo-hd
branch
from
April 16, 2024 12:22
3c8d1e8
to
540b7ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of small tweaks from the UTXO-HD branch. Best reviewed commit by commit, they are independent.