Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some code from the UTXO-HD branch to main #1054

Merged
merged 18 commits into from
Apr 16, 2024
Merged

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Apr 10, 2024

This is a collection of small tweaks from the UTXO-HD branch. Best reviewed commit by commit, they are independent.

@jasagredo jasagredo force-pushed the js/port-some-utxo-hd branch 5 times, most recently from 8995649 to 1e29f56 Compare April 11, 2024 11:35
@jasagredo
Copy link
Contributor Author

Follow-ups:

  • ChainDB arguments and initialization

@jasagredo jasagredo marked this pull request as ready for review April 11, 2024 13:21
@jasagredo jasagredo requested a review from a team as a code owner April 11, 2024 13:21
@jasagredo jasagredo force-pushed the js/port-some-utxo-hd branch 4 times, most recently from 8b974a4 to 39c6de7 Compare April 15, 2024 10:38
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I made some minor comments (eg naming, etc).

I did not thoroughly check the changelog for exhaustiveness.

jasagredo and others added 4 commits April 16, 2024 11:51
@jasagredo jasagredo added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit d6d29fa Apr 16, 2024
15 checks passed
@jasagredo jasagredo deleted the js/port-some-utxo-hd branch April 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants