-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the arguments for the DBs #1059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba7a94c
to
dde1bef
Compare
8b974a4
to
39c6de7
Compare
dde1bef
to
bd28e57
Compare
jorisdral
reviewed
Apr 15, 2024
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/ChainSel.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/Args.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/Args.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/VolatileDB/Impl.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/unstable-consensus-testlib/Test/Util/ChainDB.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/unstable-cardano-tools/Cardano/Tools/DBAnalyser/Run.hs
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/unstable-cardano-tools/Cardano/Tools/DBSynthesizer/Run.hs
Show resolved
Hide resolved
ouroboros-consensus-diffusion/changelog.d/chaindb-args-javier.md
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/Node.hs
Outdated
Show resolved
Hide resolved
39c6de7
to
e0a6bf3
Compare
1b49787
to
0039944
Compare
aec635d
to
8a152c5
Compare
0039944
to
e99363f
Compare
dnadales
approved these changes
Apr 16, 2024
ouroboros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/Node.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/Node.hs
Outdated
Show resolved
Hide resolved
8a152c5
to
3c8d1e8
Compare
e99363f
to
cd9d841
Compare
I would argue that this also can close #630 |
3c8d1e8
to
540b7ae
Compare
cd9d841
to
5717314
Compare
5cb8bb9
to
ec0fa2d
Compare
- Tweak the ChainDB arguments: - Remove unused fields in `CDB`: - `cdbTraceLedger` this was *always* set to nullTracer, furthermore it would trace the whole LedgerDB. - `cdbChunkInfo` was never accessed from the ChainDB. - `cdbCheckIntegrity` was never accessed from the ChainDB. - Transform `ChainDbArgs` into an isomorphic product of the different arguments of the inner databases. - Define most common operations on `ChainDbArgs` as separate functions: `ensureValidateAll`, `updateTracer` and `updateDiskPolicyArgs` - Tweak the LgrDB arguments: - `LgrDB.cfg` and `LgrDbArgs.lgrConfig` are now `LedgerDbCfg (ExtLedgerState blk)` instead of `TopLevelConfig blk`. - `defaultArgs` no longer expects a filesystem. - Tweak the ImmutableDB arguments: - `defaultArgs` no longer expects a filesystem. - Tweak the VolatileDB arguments: - `defaultArgs` no longer expects a filesystem. - Hide the `Identity`/`Defaults` types in `Ouroboros.Consensus.Util.Args` in favor of `Complete`/`Incomplete`. - Expose `noDefault` to replace `NoDefault`.
ec0fa2d
to
91b2dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDB
:cdbTraceLedger
this was always set to nullTracer, furthermore it would trace the whole LedgerDB.cdbChunkInfo
was never accessed from the ChainDB.cdbCheckIntegrity
was never accessed from the ChainDB.ChainDbArgs
into an isomorphic product of the different arguments of the inner databases.ChainDbArgs
as separate functions:ensureValidateAll
,updateTracer
andupdateDiskPolicyArgs
LgrDB.cfg
andLgrDbArgs.lgrConfig
are nowLedgerDbCfg (ExtLedgerState blk)
instead ofTopLevelConfig blk
.defaultArgs
no longer expects a filesystem.defaultArgs
no longer expects a filesystem.defaultArgs
no longer expects a filesystem.Identity
/Defaults
types inOuroboros.Consensus.Util.Args
in favor ofComplete
/Incomplete
.noDefault
to replaceNoDefault
.