Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not even propagate future headers #525

Merged
merged 4 commits into from Nov 30, 2023
Merged

Do not even propagate future headers #525

merged 4 commits into from Nov 30, 2023

Commits on Nov 30, 2023

  1. consensus-test: improve legibility in the ChainSync client test driver 

    Main change: remove the LogicalClock, since it's quite a bit of indirection
with no real gain. Also, remove -XRecordWildCards.
    @nfrisby
    nfrisby committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    53223fd View commit details
    Browse the repository at this point in the history

  2. consensus: do not even propagate future headers 

    This an aggressively-simple interpretation of the easy part of Ouroboros
Chronos in the presence of The Header-Body Split. (The hard part is the
_synchronization beacons_---which need to be propagated promptly, and will be
implemented much later.)

Other less-aggressive interpretations would propagate future headers/blocks but
set them aside. But this seems much simpler and within an RTT or two, assuming
eg the NTP clients are well-configured.
    @nfrisby
    nfrisby committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2f90f2c View commit details
    Browse the repository at this point in the history

  3. consensus-test: include near-future headers in ChainSync client test 

    This now exercises the real ChainSync InFutureCheck.
    @nfrisby
    nfrisby committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a39cd95 View commit details
    Browse the repository at this point in the history

  4. Update changelogs for ChainSync.InFutureCheck

    @nfrisby
    nfrisby committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    8bb0efc View commit details
    Browse the repository at this point in the history