Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptonite v 0.25 uses libb2 with avx issue #2476

Closed
bkohlhauff opened this issue Jul 28, 2020 · 2 comments · Fixed by #2477
Closed

cryptonite v 0.25 uses libb2 with avx issue #2476

bkohlhauff opened this issue Jul 28, 2020 · 2 comments · Fixed by #2477

Comments

@bkohlhauff
Copy link

There is an issue running cardano-node on CPUs without AVX support due to an underlying bug in the blake2/libb2 library which is used by cryptonite and appears to have been fixed with the updated libb2 in cryptonite v0.26 can the project be updated to use 0.26 or newer of the cryptonite library?
@mrBliss
Copy link
Contributor

mrBliss commented Jul 29, 2020

It seems everything compiles with cryptonite 0.26 and 0.27 as well, so we can relax the constraint to cryptonite >= 0.25 && <0.28. (To compile with 0.27, #2445 is needed.)

mrBliss added a commit that referenced this issue Jul 29, 2020
@mrBliss
Allow cryptonite 0.26 and 0.27 too
1431f4d 
Fixes #2476.
@mrBliss mrBliss mentioned this issue Jul 29, 2020
Merged
@bkohlhauff
Copy link
Author

Thanks for looking into this!

mrBliss added a commit that referenced this issue Jul 31, 2020
@mrBliss
Allow cryptonite 0.26 and 0.27 too
1969a0d 
Fixes #2476.
iohk-bors bot added a commit that referenced this issue Jul 31, 2020
@iohk-bors @mrBliss
Merge #2477
8a70313 
2477: Allow cryptonite 0.26 and 0.27 too r=mrBliss a=mrBliss

Fixes #2476.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
iohk-bors bot added a commit that referenced this issue Jul 31, 2020
@iohk-bors @mrBliss
Merge #2477
a3e61f9 
2477: Allow cryptonite 0.26 and 0.27 too r=mrBliss a=mrBliss

Fixes #2476.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
@iohk-bors iohk-bors bot closed this as completed in d76d777 Jul 31, 2020
nc6 pushed a commit that referenced this issue Aug 3, 2020
@mrBliss @nc6
Allow cryptonite 0.26 and 0.27 too
740a982 
Fixes #2476.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow cryptonite 0.26 and 0.27 too IntersectMBO/ouroboros-network
2 participants
@mrBliss @bkohlhauff