Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Arbitrary Block validity tests #3134

Closed
nfrisby opened this issue May 12, 2021 · 3 comments
Closed

Re-enable Arbitrary Block validity tests #3134

nfrisby opened this issue May 12, 2021 · 3 comments
Labels
consensus issues related to ouroboros-consensus testing

Comments

@nfrisby
Copy link
Contributor

nfrisby commented May 12, 2021

Commit IntersectMBO/cardano-ledger@7447dd7 changed the Arbitrary Block instance to no longer ensure any relationship between the component block header and block body.

This change is causing some Consensus tests to now fail.

https://github.com/input-output-hk/ouroboros-network/blob/437d7160079c83c4632fe0a42c596e5105c59a4d/ouroboros-consensus-test/src/Test/Util/Serialisation/Roundtrip.hs#L446-L463

https://github.com/input-output-hk/ouroboros-network/blob/c82309f403e99d916a76bb4d96d6812fb0a9db81/ouroboros-consensus-shelley-test/test/Test/Consensus/Shelley/Serialisation.hs#L41-L46

The "integrity" tests test that we can detect corruption. And that means we need a baseline of "not corrupted" which requires a sufficiently careful generator for headers and for blocks.
@nfrisby nfrisby added consensus issues related to ouroboros-consensus testing priority high labels May 12, 2021
@nfrisby
Copy link
Contributor Author

nfrisby commented May 12, 2021

@JaredCorduan

nfrisby added a commit that referenced this issue May 12, 2021
@nfrisby
ouroboros-shelley-test: temporarily disable Arbitrary Block validity …
6661995 
…tests

The Ledger recently changes its Shelley block generator to be "dumb". It no
longer generates valid blocks. We've raised the Issue.

Until it's resolved, we're disabling those tests, so that we can proceed with
the Alonzo integration.

See the tracking Issue #3134.
@nfrisby nfrisby mentioned this issue May 12, 2021
Merged
JaredCorduan pushed a commit to IntersectMBO/cardano-ledger that referenced this issue May 12, 2021
add a more coherent (less random) block generator
53b4100 
In 7447dd7 we changed genBlock to
produce blocks with more noise. This turns out to have broken some tests
in the consensus layer that relied on some coherency in the block.

See IntersectMBO/ouroboros-network#3134

To fix this, we add a new block generator genCoherentBlock, which is
almost exactly like the previous genBlock, but does not require the
PreAlonzo constraint.
@JaredCorduan JaredCorduan mentioned this issue May 12, 2021
Merged
@nfrisby
Copy link
Contributor Author

nfrisby commented May 12, 2021 •
edited

PR IntersectMBO/cardano-ledger#2280 will give us what we need to close as part of our PR #3130

JaredCorduan pushed a commit to IntersectMBO/cardano-ledger that referenced this issue May 12, 2021
add a more coherent (less random) block generator
a50b834 
In 7447dd7 we changed genBlock to
produce blocks with more noise. This turns out to have broken some tests
in the consensus layer that relied on some coherency in the block.

See IntersectMBO/ouroboros-network#3134

To fix this, we add a new block generator genCoherentBlock, which is
almost exactly like the previous genBlock, but does not require the
PreAlonzo constraint.
@nfrisby
Copy link
Contributor Author

nfrisby commented May 14, 2021

I meant to Close this as part of the previous message.

@nfrisby nfrisby closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfrisby