consensus: handle EBBs in rewindHeaderState #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrisby
added
bug
nfrisby
changed the title
nfrisby
force-pushed
the
nfrisby/issue-1690
branch
from
d1b4d92
to
b997eef
Compare
nfrisby
changed the title
nfrisby
commented
Feb 25, 2020
| , headerStateAnchor = headerStateAnchor | ||
| } | ||
| where | ||
| rolledBack :: AnnTip blk -> Bool | ||
| rolledBack t = annTipPoint t > p | ||
| rollBack :: AnnTip blk -> Bool |
There was a problem hiding this comment.
The name change was accidental, but doesn't seem worth another force push :)
There was a problem hiding this comment.
Did you see #1690 (comment)?
There was a problem hiding this comment.
I did now. I've adopted it.
nfrisby
force-pushed
the
nfrisby/issue-1690
branch
from
b997eef
to
e09503c
Compare
edsko
approved these changes
Feb 25, 2020
|
@nfrisby feel free to |
|
My big update to PR #1506 is still a work-in-progress, but I do think it is "feature complete" with respect to PBFT and RealPBFT. In particular the commit on this PR passed hundreds of thousands of tests (though I can't be sure how many exercised it), including a couple repros derived from this PR's Issue. So I'm going to merge. Thanks. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1690.
I believe this bug was masked by Issue #1489; I discovered it and confirmed that this patch fixes it on my related WIP branch. This PR does not include a repro for this bug, but that branch does, and PR #1506 will as soon as I'm able to update it with that WIP branch -- that's my current focus.