Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InspectLedger instance for Shelley #2508

Closed
wants to merge 2 commits into from
Closed

InspectLedger instance for Shelley #2508

wants to merge 2 commits into from

Conversation

mrBliss
Copy link
Contributor

@mrBliss mrBliss commented Aug 12, 2020

Fixes #2452 and #2471.

@edsko edsko self-assigned this Sep 14, 2020
@edsko
Copy link
Contributor

edsko commented Sep 22, 2020

I'll take over this PR.

edsko
edsko reviewed Sep 22, 2020
View reviewed changes
ouroboros-consensus-cardano/src/Ouroboros/Consensus/Cardano/CanHardFork.hs
-> Word16 -- ^ Next era's major protocol version
-> LedgerState (ShelleyBlock sc)
-> Maybe EpochNo
shelleyTransition = undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

ouroboros-consensus-cardano/src/Ouroboros/Consensus/Cardano/Node.hs
-- in the partial ledger config with the correct one.
History.dummyEpochInfo
maxMajorPV
, shelleyTriggerHardFork = TriggerHardForkNever
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@edsko edsko mentioned this pull request Sep 22, 2020
Merged
@edsko
Copy link
Contributor

edsko commented Sep 22, 2020

Closing this in favour of #2627. Leaving this as a separate PR just in case we want to compare to what was done here.

@edsko edsko closed this Sep 22, 2020
iohk-bors bot added a commit that referenced this pull request Sep 28, 2020
@iohk-bors @edsko
Merge #2627
66195ab 
2627: InspectLedger instance for Shelley r=edsko a=edsko

This PR include #2621 and #2626.

Replaces #2508. 

Co-authored-by: Edsko de Vries <edsko@well-typed.com>
iohk-bors bot added a commit that referenced this pull request Sep 28, 2020
@iohk-bors @edsko
Merge #2627
aa723b8 
2627: InspectLedger instance for Shelley r=edsko a=edsko

This PR include #2621 and #2626.

Replaces #2508. 

Co-authored-by: Edsko de Vries <edsko@well-typed.com>
@mrBliss mrBliss deleted the mrBliss/shelley-inspectledger branch November 11, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsko edsko edsko left review comments

Assignees

@edsko edsko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add LedgerUpdate instance for Shelley
2 participants
@mrBliss @edsko