Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to compile on ghc-8.10.2 #2652

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fix to compile on ghc-8.10.2 #2652

merged 1 commit into from
Oct 6, 2020

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 1, 2020

No description provided.

@mrBliss mrBliss mentioned this pull request Oct 1, 2020
Merged
coot
coot previously requested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this commit into the syntactic and non-syntactic change.

typed-protocols-examples/src/Network/TypedProtocol/Codec.hs Outdated Show resolved Hide resolved
@newhoggy newhoggy requested a review from coot October 5, 2020 23:07
@newhoggy newhoggy dismissed coot’s stale review October 5, 2020 23:12

Concerns addressed

coot
coot previously requested changes Oct 6, 2020
View reviewed changes
typed-protocols-examples/src/Network/TypedProtocol/Codec.hs Outdated Show resolved Hide resolved
@newhoggy newhoggy requested a review from coot October 6, 2020 06:45
@newhoggy newhoggy dismissed coot’s stale review October 6, 2020 06:46

Accept suggestions

coot
coot approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@mrBliss
Copy link
Contributor

mrBliss commented Oct 6, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 6, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit a535a47 into master Oct 6, 2020
@iohk-bors iohk-bors bot deleted the ghc-8.10.2 branch October 6, 2020 08:12
@mark-stopka mark-stopka mentioned this pull request Oct 15, 2020
Closed
coot pushed a commit that referenced this pull request May 16, 2022
@iohk-bors @newhoggy
Merge #2652
004f42d 
2652: Fix to compile on ghc-8.10.2 r=mrBliss a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@erikd erikd Awaiting requested review from erikd

@intricate intricate Awaiting requested review from intricate

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@mrBliss mrBliss Awaiting requested review from mrBliss

@dcoutts dcoutts Awaiting requested review from dcoutts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@newhoggy @mrBliss @coot