Update the ledger and improve the compile time of Shelley.Ledger.Query #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name was inconsistent: `Right` is a constructor and `Maybe` is a type. `eitherToMaybe` already existed in `Ouroboros.Consensus.Byron.Crypto.DSIGN`. Remove this one and reuse the one from `Ouroboros.Consensus.Util`.
mrBliss
commented
Oct 29, 2020
| @@ -667,7 +667,8 @@ translateLedgerViewAcrossShelley = | |||
| -------------------------------------------------------------------------------} | |||
|
|
|||
| translateLedgerStateShelleyToAllegraWrapper :: | |||
| RequiringBoth | |||
| PraosCrypto c | |||
| => RequiringBoth | |||
ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
This pulls in IntersectMBO/cardano-ledger#1944 which moves `ShelleyBasedEra` and `TPraosCrypto` (renamed to `PraosCrypto`) to `cardano-ledger-specs`.
The initial reason for doing this was to reduce the atrocious compile time of the `Ouroboros.Consensus.Shelley.Ledger.Ledger`, 3 min on my machine! Splitting off `Query` didn't help much, that module now takes 2 min 30 sec to compile on my machine. Nevertheless, splitting it off makes sense, even if it doesn't reduce compile time much.
Before this change, it took 2m30s to compile `Ouroboros.Consensus.Shelley.Ledger.Query` on my machine. After, mere seconds.
mrBliss
force-pushed
the
mrBliss/ledger-update
branch
from
b67b945
to
bfbf856
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for more details. This is preparation for #2679.