-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cardano-ledger-specs and fix breaking change #3282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to fix the sha hash for the ledger repo. I've suggested the fix.
Sorry I was careless and used |
Hi @kk-hainq , thanks for fixing this for us. Please squash your two commits into one before merging this PR. Otherwise, LGTM. Thanks. |
828e6cc
to
a403095
Compare
I have, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much. Approving. And I'll merge too.
bors r+ |
Hi @kk-hainq. Thanks again for the helpful commit. I was a bit lax this time, since this commit is so simple. But generally -- and usually even for a small one -- we'd like to have a few more details in the commit message and a non-empty PR description. (The description can even just say "Please see the commit messages" eg). Thanks again! |
Yes sir. I should have at least added a reference to the breaking commit in ledger. Will add more information next time! |
Build succeeded: |
No description provided.