Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ordering peers based on peerid in blockfetch #3535

Merged
merged 2 commits into from Jan 20, 2022
Merged

Avoid ordering peers based on peerid in blockfetch #3535

merged 2 commits into from Jan 20, 2022

Commits on Jan 20, 2022

  1. Avoid ordering peers based on peerid in blockfetch 

    Peers where ordered based on SockAddr, which generally meant that all
peers would pick the same second choice peer to download blocks from in
Deadline mode. And the same third pick and so on.

This changes ranking so that peers are sorted based on G.
    @karknu
    karknu committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    1b76572 View commit details
    Browse the repository at this point in the history

  2. Stable PeerGSV ordering 

    In case two peer's G where close to each other the ordering wasn't
stable. This fixes the ordering and adds matching tests.
    @karknu
    karknu committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    8bb40ce View commit details
    Browse the repository at this point in the history