Remove Shelley genesis info from the ledger configuration #4091
+1,200
−361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed as of [this PR](#4007)
... since this is no longer defined. We have a `ShelleyBasedEra` symbol, but that refers to a type class.
... add a FIXME that should be addressed before this PR is merged.
I do not know if we should mention 'ProtocolTransitionParamsShelleyBased' here instead.
bartfrenk
force-pushed
the
bartfrenk/3976/remove-shelley-genesis
branch
from
f59ec93
to
a1588d9
Compare
bartfrenk
force-pushed
the
bartfrenk/3976/remove-shelley-genesis
branch
2 times, most recently
from
5d3ebad
to
f762ce0
Compare
To avoid breaking backwards-compatibility of the interface we add ShelleyGenesis to BlockConfig, and use that to serve the GetGenesisConfig query.
bartfrenk
force-pushed
the
bartfrenk/3976/remove-shelley-genesis
branch
from
f762ce0
to
41ff462
Compare
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 14, 2022
Change is required for a simpler consensus LedgerConfig here: IntersectMBO/ouroboros-network#4091.
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 21, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 22, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 22, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
bartfrenk
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 23, 2022
… ShelleyGenesis instances To support the ouroboros-network PR here: IntersectMBO/ouroboros-network#4091
dnadales
force-pushed
the
nfrisby/issue-3962-conway
branch
from
634ea6c
to
93c9adc
Compare
dnadales
force-pushed
the
nfrisby/issue-3962-conway
branch
from
0c4fdc4
to
2a0eae7
Compare
dnadales
force-pushed
the
nfrisby/issue-3962-conway
branch
2 times, most recently
from
49da2d6
to
903bcc6
Compare
|
What is the status of this PR? IntersectMBO/cardano-ledger#3053 has been merged and now I am trying to integrate newest ledger, but I am running into inability of consensus to handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes IntersectMBO/ouroboros-consensus#409. Requires IntersectMBO/cardano-ledger#3053.
This PR does three things:
ShelleyGenesisfrom theShelleyLedgerConfig.ShelleyGenesistoShelleyBlockConfigand reimplementsGetGenesisConfigin terms of thatShelleyGenesisvalue.TranslateEra * ShelleyGenesisinstances in the aforementionedcardano-ledgerPR.The first and third points close IntersectMBO/ouroboros-consensus#409. The second point keeps the (query) interface backwards compatible.
Checklist