-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine executable dependencies #213
Conversation
I tried to have nix provide the I think that removing them from cabal is a very good idea, but adding them to nix is going to create problems for us down the road (which in fact, it already has). |
@raduom I indeed built on your previous work and saw the removal commit. That is why I was still very vague with the Overall, I don't think adding For the issue, do you have notes on previously found problems? If |
I've tested this PR and the node builds without linking to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Co-authored-by: Radu Ometita <radu.ometita@gmail.com>
Thank you @raduom for your insights and help on Slack! |
Complicating our Cabal setup to build executable dependencies is not nice. This PR pulls
cardano-cli
,cardano-node
, andcardano-wallet
to the Nix shell with a few words here and there directing people to the original repositories to find their best installation option. When people do want to build the executables from the source, they should do it in their respective clones, not changing commit hashes and doing it here.The net effects of this PR are:
cardano-cli
,cardano-node
,cardano-wallet
available innix-shell
by default.cardano-node
,cardano-cli
,cardano-config
, and anoptparse-applicative
fork removed from ourcabal.project
.The second commit is only
updateMaterialized
, so reviewing the others should be sufficient.Pre-submit checklist: