Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-3501: Remove txs from chain index #315

Merged
merged 17 commits into from Feb 22, 2022
Merged

SCP-3501: Remove txs from chain index #315

merged 17 commits into from Feb 22, 2022

Conversation

ak3n
Copy link
Contributor

@ak3n ak3n commented Feb 16, 2022

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@ak3n ak3n changed the title Remove txs from chain index SCP-3501: Remove txs from chain index Feb 18, 2022
@ak3n ak3n marked this pull request as ready for review February 18, 2022 10:18
@ak3n ak3n requested a review from koslambrou February 18, 2022 10:20
Copy link
Contributor

@koslambrou koslambrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good. However, I would also add a property test to ensure this works as expected. Here's an idea.

In HandlerSpec, you can add a property test which:

  • calls appendBlock
  • for all possibles addresses (or at least one address), call utxoSetAtAddress
  • Then call getUtxoutFromRef for each utxo
  • Verify the result is not Nothing

plutus-chain-index-core/src/Plutus/ChainIndex/Handlers.hs Outdated Show resolved Hide resolved
@ak3n ak3n requested a review from koslambrou February 22, 2022 08:40
@ak3n ak3n merged commit 65220a0 into main Feb 22, 2022
@ak3n ak3n deleted the remove-txs-chain-index branch February 22, 2022 12:10
@koslambrou koslambrou restored the remove-txs-chain-index branch April 13, 2022 19:12
@ak3n ak3n deleted the remove-txs-chain-index branch April 22, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants