PLT-713: must mint value with reference #758
Conversation
ak3n
force-pushed
the
must-mint-value-reference
branch
from
ca1205d
to
9f1bf73
Compare
plutus-ledger-constraints/src/Ledger/Constraints/TxConstraints.hs
Outdated
Show resolved
Hide resolved
| @@ -111,7 +111,7 @@ checkTxConstraint ctx@ScriptContext{scriptContextTxInfo} = \case | |||
| -- gives us the redeemer's hash, but 'MustSpendScriptOutput' gives | |||
| -- us the full redeemer | |||
| $ isJust (V.findTxInByTxOutRef txOutRef scriptContextTxInfo) | |||
| MustMintValue mps _ tn v -> | |||
| MustMintValue mps _ tn v _ -> | |||
There was a problem hiding this comment.
Shouldn't it fail if a reference script is given?
There was a problem hiding this comment.
I think it's ok to assume it'll only get this far without a reference script in the tx. The same is done for MustSpendScriptOutput.
There was a problem hiding this comment.
I agree with @james-iohk that we don't have to check because when it is not Nothing construction of the transaction would have already failed.
Of course it is possible to construct the transaction yourself and use this constraint only in the script, and then a "cheating" transaction could store the minting script in the body instead of using the reference script. Perhaps this could theoretically be a security risk in some way? I think it's fine to just document that MustMintValue does not check on-chain that a reference script is used, instead of wasting valuable script resources to do the check.
There was a problem hiding this comment.
store the minting script in the body instead of using the reference script
This wouldn't pass phase-1 because reference inputs are prohibited when V1 scripts are involved. Forced to remove the reference script altogether, you're back to valid legacy behaviour.
Even if using V2, you cannot have the same script in the txbody and as reference.
ak3n
force-pushed
the
must-mint-value-reference
branch
from
3bd6549
to
6bf2168
Compare
| @@ -127,6 +127,16 @@ toCardanoScriptWitness datum redeemer (P.Versioned script lang) = (case lang of | |||
| ) <*> pure datum | |||
| <*> pure (C.fromPlutusData $ PV1.toData redeemer) | |||
| <*> pure zeroExecutionUnits | |||
| toCardanoScriptWitness datum redeemer (Right (P.Versioned ref lang)) = (case lang of | |||
There was a problem hiding this comment.
It should be possible to merge this code with the code for toCardanoTxInWitness.
ak3n
force-pushed
the
must-mint-value-reference
branch
from
d24b3a2
to
1482225
Compare
fix Merge two cases of toCardanoScriptWitness into one Rename txMintingScripts to txMintingWitnesses. Use it for references. nits fix wip Apply James's patch Update plutus-use-cases golden files
ak3n
force-pushed
the
must-mint-value-reference
branch
from
1482225
to
2b5c043
Compare
Pre-submit checklist: