SCP-845 - Add linting for undefined ChoiceValue usage #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmish111
approved these changes
Jul 9, 2020
| @@ -97,6 +98,7 @@ instance showWarningDetail :: Show WarningDetail where | |||
| show UnreachableCaseEmptyChoice = "This case will never be used, because there are no options to choose" | |||
| show UnreachableCaseFalseNotify = "This case will never be used, because the Observation is always false" | |||
| show UnreachableContract = "This contract is unreachable" | |||
| show UndefinedChoice = "The contract tries to use a ChoiceId that has not been input by a When" | |||
There was a problem hiding this comment.
Perhaps this message (and UndefinedUse) should not use the word tries but in stead should explain that the default value of 0 will be used?
There was a problem hiding this comment.
Good idea, I don't want to wait for the CI again just for that, but I will change it when I get a chance :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed in https://pablo.marlowe.iohkdev.io/