Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the Plutus playground client. #2629

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Conversation

merivale
Copy link
Contributor

New guy moves in a couple of months ago, now he wants to redecorate...

This PR moves code around with a view to:

  • making more room for the impending remodelling (SCP-1393, SCP-1562)
  • bringing things closer to some conventions adopted in the Marlowe playground client code
  • dividing things up according to (what strike me as) natural lines that have emerged since the previous structure was put in place
  • making all exports explicit.

Doubts/questions:

  • Is having separate Action.Lenses and Wallet.Lenses modules too much? Maybe the lenses there should all go together in Simulator.Lenses (which doesn't exist, but which might deserve to exist after the remodelling).
  • Should it be Simulator.View or Simulation.View? I chose the former to match Editor, and because it's called the simulator on the actual page. But its purpose is to visualise the simulations, and Simulation matches other things (Wallet, Action, Transaction).

Copy link
Contributor

@krisajenkins krisajenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank the lord that the git CLI has syntax highlighting for, "this line didn't change, it just moved," these days. That made it easy.

@merivale merivale merged commit 72197eb into master Jan 21, 2021
@merivale merivale deleted the pp-client-refactoring branch January 21, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants