scp-2091: Marlowe Dashboard Client: Implement toast notification #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merivale
approved these changes
Apr 15, 2021
Comment on lines
+268
to
+269
| let | ||
| networkErrorToast = \_ -> addToast $ connectivityErrorToast "Couldn't generate wallet" |
There was a problem hiding this comment.
I feel this (and line 234 above) should be factored out somehow, but I'm not immediately sure how. Just a note for the future...
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements toast notification for success and error messages.
Successful mobile
Successful desktop
Error mobile collapsed
Error mobile expanded
Error desktop collapsed
Error desktop expanded
Pre-submit checklist:
Pre-merge checklist: