Add improvements to the PIR compiler #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jakzale
commented
Aug 2, 2021
| @@ -44,6 +44,8 @@ import Data.Proxy | |||
| import Data.Text.Prettyprint.Doc | |||
| import qualified Data.Typeable as GHC | |||
|
|
|||
| type PrettyPrintable uni fun = ( PLC.GShow uni, PLC.Closed uni, uni `PLC.Everywhere` PrettyConst, Pretty fun) | |||
There was a problem hiding this comment.
@effectfully I was thinking about adding such constraint somewhere, do you thing it is sufficient?
There was a problem hiding this comment.
We should indeed put this somewhere more easily accessible and use it.
There was a problem hiding this comment.
Maybe from PlutusCore.Core?
There was a problem hiding this comment.
@michaelpj, I think I will leave this to a subsequent PR.
michaelpj
reviewed
Aug 2, 2021
jakzale
force-pushed
the
jakzale/pir-compiler
branch
3 times, most recently
from
597960b
to
ddc169d
Compare
jakzale
force-pushed
the
jakzale/pir-compiler
branch
from
ddc169d
to
47b4dbc
Compare
- pedantic typechecking will typecheck between simplifier passes, - add option for being verbose about simplifier passes, - add option for dumping PIR to stdout before and after a pass, - add option for specifying max number of iterations, - add option for controlling each simplifier pass, - run the simplifier 8 times by default.
jakzale
force-pushed
the
jakzale/pir-compiler
branch
from
47b4dbc
to
34cfab9
Compare
michaelpj
reviewed
Aug 5, 2021
| ) | ||
| => a -> m (UPLC.Term UPLC.NamedDeBruijn uni fun ()) | ||
| safeLift x = do | ||
| lifted <- liftQuote $ runDefT () $ Lift.lift x | ||
| tcConfig <- PLC.getDefTypeCheckConfig $ Original () | ||
| compiled <- flip runReaderT (toDefaultCompilationCtx tcConfig) $ compileTerm lifted | ||
| -- NOTE: Disabling simplifier, as it takes a lot of time during runtime |
There was a problem hiding this comment.
Is this true? Or is this only true when we inline types? I think we should turn this back on again, but I want to merge this so let's do it later.
michaelpj
approved these changes
Aug 5, 2021
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submit checklist: