Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing section to CONTRIBUTING #5563

Merged
merged 1 commit into from Sep 27, 2023
Merged

Add testing section to CONTRIBUTING #5563

merged 1 commit into from Sep 27, 2023

Conversation

bezirg
Copy link
Contributor

@bezirg bezirg commented Sep 27, 2023

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@bezirg bezirg added the No Changelog Required Add this to skip the Changelog Check label Sep 27, 2023
@michaelpj michaelpj enabled auto-merge (squash) September 27, 2023 14:55
@michaelpj michaelpj merged commit 2beefec into master Sep 27, 2023
8 checks passed
@michaelpj michaelpj deleted the contrib-test branch September 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bezirg @michaelpj